Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added RadioButton styles #1078

Closed
wants to merge 1 commit into from
Closed

docs: added RadioButton styles #1078

wants to merge 1 commit into from

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jul 24, 2023 •
edited
Loading

GitHub Issue: #1063

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Description

  • Adds documentation page for RadioButton with its Material styles and lightweight styling keys.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Waiting for #1069 to complete before merging this one.

@rajamatt rajamatt self-assigned this Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Jul 25, 2023
View reviewed changes
doc/styles/RadioButton.md Outdated Show resolved Hide resolved
This was referenced Jul 25, 2023
Closed
Closed
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

@rajamatt rajamatt force-pushed the dev/mara/docs-radiobutton-styling branch from d900ed6 to 3596933 Compare July 25, 2023 15:51
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some resources that not found in the current state of this branch
to name a few: RadioButtonPadding, RadioButtonCheckHeight
if they are coming from another pr, please link to that pr
and hold this pr until the other is completed

doc/styles/RadioButton.md Outdated Show resolved Hide resolved
@rajamatt
Copy link
Contributor Author

Waiting for #1069 to complete before merging this one.

@rajamatt
docs: added RadioButton styles
1838f52 
fix: switched columns & added default

fix: removing removed resources

fix: switched columns & added default

docs: added RadioButton styles

fix: xiao changes

docs: added RadioButton styles
@rajamatt rajamatt force-pushed the dev/mara/docs-radiobutton-styling branch from 9bb3b83 to 1838f52 Compare July 25, 2023 18:29
@rajamatt rajamatt requested a review from Xiaoy312 July 25, 2023 18:30
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1078.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Aug 9, 2023

Closed since this will be addressed by #1118

@kazo0 kazo0 closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 Awaiting requested review from kazo0

@agneszitte agneszitte Awaiting requested review from agneszitte

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajamatt @kazo0 @Xiaoy312