Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FAB): lightweight styling for button #1100

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

carlh98
Copy link
Contributor

@carlh98 carlh98 commented Jul 26, 2023

GitHub Issue: #1067

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Description

Moving non-brush resources into ResourceDictionary.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

@carlh98 carlh98 changed the title refactor(FloatingActionButton): lightweight styling for button refactor(FAB): lightweight styling for button Jul 26, 2023
@carlh98 carlh98 force-pushed the dev/cama/lightweight-styling-FAB branch from 45c4948 to a75cbd8 Compare July 26, 2023 20:32
@carlh98 carlh98 force-pushed the dev/cama/lightweight-styling-FAB branch from a75cbd8 to eb4fb3f Compare July 31, 2023 18:36
@kazo0 kazo0 merged commit 75e56ee into master Aug 7, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/cama/lightweight-styling-FAB branch August 7, 2023 22:03
@kazo0
Copy link
Collaborator

kazo0 commented Aug 7, 2023

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 7, 2023

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants