Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse signup redirect for reset password redirect #64

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ldko
Copy link
Member

@ldko ldko commented Sep 13, 2024

This just changes the URL a user gets redirected to when submitting a successful change password form to use the same setting that is used when a new user sets their password for the first time. For our Edit site, which uses the invite app, it has been going to the login form of the invite app, but since we use it for Edit users to generally reset their password, we want to be able to configure it to go to the Edit site login view instead.

ping @clarktr1 @somexpert @htarver this is ready for review

@somexpert
Copy link
Member

Looks good to me and behaves as described. I have just one small comment: should we add that setting to the test settings, in case you want to test password resets locally? You'd also need emailing set up, which is a pain and not what I'd expect, so I'm alright either way. 👍

@ldko
Copy link
Member Author

ldko commented Sep 13, 2024

I opted not to add it as a test setting because out of context of the Edit project, which this app here in this repo is, I didn't know what I would set it to, where locally I set it to the full URL Edit app login.

Copy link

@clarktr1 clarktr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ldko ldko merged commit 4a116f8 into master Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants