Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the uptest tool and the associated libraries #194

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ulucinar
Copy link
Contributor

Description of your changes

We are moving the uptest tool to its own repository under the crossplane Github organization, https://github.com/crossplane/uptest. The reusable workflows for the official provider repositories and the official providers CI tooling stays in this repo. Here's the current list of reusable workflows & the tooling that will stay in this repo:

  • .github/workflows/provider-ci.yml
  • .github/workflows/pr-comment-trigger.yml
  • .github/workflows/provider-publish-service-artifacts.yml
  • .github/workflows/native-provider-bump.yml
  • .github/workflows/provider-backport.yml
  • .github/workflows/issue-triage.yml
  • .github/workflows/pr-triage.yml
  • .github/workflows/provider-tag.yml
  • .github/workflows/provider-updoc.yml
  • .github/workflows/scan.yml
  • .github/workflows/provider-commands.yml
  • crddiff
  • buildtagger
  • lint-provider-family
  • perf
  • ttr
  • updoc

This PR also updates the repo's README.md to define the new scope. We are also planning to rename this repo to upbound/official-providers-ci after the uptest tool moves into its own repo.

There are some uptest related PRs in this repo that we will need to reopen in the new repository https://github.com/crossplane/uptest (ignoring the renovate ones as renovate should reopen them as needed in the tool's new home):

We will also update the official provider repositories to consume the tooling from the release S3 bucket once we do the new releases for them. Although Github will handle the URL redirection as discussed below, we will also update the reusable workflow references so that they point to https://github.com/upbound/official-providers-ci once the renaming is done.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • make build.all can successfully build all the remaining tools
  • make lint reports no issues
  • No changes in the source tree rooted at .github. The reusable workflows are intact. Github already handles URL redirection from https://github.com/upbound/uptest to https://github.com/upbound/official-providers-ci once the repo is renamed. This provides backwards-compatibility for the clients of the reusable workflows.

- Update README.md so that it mentions about the remaining tools
  and the reusable CI workflows in the repository.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit beeb88e into upbound:main Mar 14, 2024
6 checks passed
@ulucinar ulucinar deleted the remove-uptest branch March 14, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants