-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch no-fork architecture #6
Conversation
c843ac8
to
8023e19
Compare
/test-examples="examples/resources/v1beta1/resource.yaml" |
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Sergen Yalçın <[email protected]>
8023e19
to
b3d1382
Compare
/test-examples="examples/resources/v1beta1/resource.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this PR @sergenyalcin. Manually tested the ResourceAction
resource and added it to the description. LGTM 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf and @sergenyalcin 🙏 I couldn't find any important issues, so I left a few nit comments 😅 The only issue I had on my local environment was with the go version specification. Please see my comments below.
Signed-off-by: Sergen Yalçın <[email protected]>
@mergenci I addressed your comments. I also realized that I haven't updated the Dockerfile. Since we can't fork cli and provider process anymore, a simpler Dockerfile is enough. I also committed this. |
/test-examples="examples/resources/v1beta1/resource.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @sergenyalcin 💪 Let's go 🙌
Description of your changes
This PR switches
provider-upjet-azapi
to no-fork architecture.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
https://github.com/upbound/provider-upjet-azapi/actions/runs/12831935067
https://github.com/upbound/provider-upjet-azapi/actions/runs/12884796491
Manually tested
ResourceAction
resource successfully and verified from Azure console: