county: Add alternateNames #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgallice
requested review from
pauloestrella1994 and
xgoffin
and removed request for
a team
xgoffin
approved these changes
Nov 27, 2024
Sypheos
approved these changes
Nov 27, 2024
| Numeric: 344, | ||
| DialingCode: "+852", | ||
| Assignment: OfficiallyAssigned, | ||
| AlternateNames: []string{"HongKong"}, |
There was a problem hiding this comment.
Should we add their name in their original language ?
tgallice
force-pushed
the
tg/add_alternate_names
branch
from
732c298 to
b892576
Compare
AlexisMontagne
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Proposal in order to be more flexible on the country name matching
What are the observable changes?
Good PR checklist
Additional Notes