Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that we were trying use regex to match ID as single digit and this did not work for more than 10 files in id #135

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Fix that we were trying use regex to match ID as single digit and this did not work for more than 10 files in id #135

merged 4 commits into from
Mar 24, 2024

Conversation

vipulnsward
Copy link
Collaborator

@vipulnsward vipulnsward commented Mar 24, 2024 •
edited
Loading

Description

  • ["group_id is invalid" error #133] Fix that we were trying use regex to match ID as single digit and this did not work for more than 10 files in id
  • This resulted in wrong group id, which made grouping not usable at all for groups with files count >= 10
  • Also some README fixes

Closes #133

Checklist

@vipulnsward
[#133] Fix that we were trying use regex to match ID as single digit …
63d83c9 
…and this did not work for more than 10 files in id
@vipulnsward vipulnsward merged commit db4cba0 into main Mar 24, 2024
34 checks passed
@vipulnsward vipulnsward deleted the gh-133 branch March 24, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedykh rsedykh rsedykh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"group_id is invalid" error
2 participants
@vipulnsward @rsedykh