fix: compatibility with TypeScript 5.5 and Yarn Berry #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc21689 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andreisergiu98
force-pushed
the
fix/typescript-compat
branch
from
a06c3ca to
efc1c3f
Compare
andreisergiu98
changed the title
andreisergiu98
changed the title
|
We could wait for this release 0no-co/graphql.web#50 and also include a version bump with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3724
Summary
type Doc = OrNever<UnresolvedType> | LocalTypewill always be any.graphqlas optional peer dependency in@urql/core,graphql.webwill be unable to resolve it when using a strict package manager like Yarn Berry.Both problems are covered by #3724
Set of changes
Which is compatible with both newer and older TypeScript versions.
graphqlas optional peer dependency for packages that are usinggraphql.webAs a sidenote, there is a
graphqlimport without fallback inurql/packages/preact-urql/src/hooks/useRequest.tsthat will also break inference, but I am not sure how would you like to handle that.