Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Omit minified files and sourcesContent in published packages #3755

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 3, 2025

Summary

We shouldn't publish with minified files due to the source map sizes and increased publish size. They're not meant to be used directly and we mostly relied on them for measurements.

Definitely a trade-off, but we shouldn't include sourcesContent. It likely doesn't help debugging much over our "half prettified" outputs and increases size substantially

Set of changes

  • Disable sourcesContent when publishing
  • Disable minified bundle output when publishing

@kitten kitten requested a review from JoviDeCroock March 3, 2025 21:00
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 011406b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@urql/exchange-auth Patch
@urql/exchange-context Patch
@urql/exchange-execute Patch
@urql/exchange-graphcache Patch
@urql/exchange-persisted Patch
@urql/exchange-populate Patch
@urql/exchange-refocus Patch
@urql/exchange-request-policy Patch
@urql/exchange-retry Patch
@urql/exchange-throw-on-error Patch
@urql/core Patch
@urql/introspection Patch
@urql/next Patch
@urql/preact Patch
urql Patch
@urql/solid Patch
@urql/storage-rn Patch
@urql/svelte Patch
@urql/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@byCedric
Copy link

byCedric commented Mar 3, 2025

thank-you

Reduces the @urql/core package size by 316.8kb / 34% ❤️

@kitten kitten merged commit 573944c into main Mar 3, 2025
13 checks passed
@kitten kitten deleted the @kitten/chore/remove-min-outputs branch March 3, 2025 21:04
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants