Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][57874] Weird formatting (analytic: limit width of analytic tag to 200px ) #79

Open
wants to merge 1 commit into
base: mit/16.0
Choose a base branch
from

Conversation

MS-OSI
Copy link

@MS-OSI MS-OSI commented Feb 17, 2025

Steps to reproduce:

  • Activate "Analytic Accounting" in Accounting settings
  • Go to Accounting / Configuration / Analytic Accounting / Analytic Accounts
  • Create an Analytic Account with a very long name (i.e. +100 chars)
  • Go to Expenses
  • Create an Expense with the created Analytic Account in the Analytic field The display of the labels in the form view should break because the badge is too long and is taking all the available width.

Solution:
Limit the width of tag badges in "analytic_distribution" widget as it is done in "many2many_tags" widget. https://github.com/odoo/odoo/blob/2f47df6663b65c4f6b6ec61f956c453e97563462/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.scss#L47-L49

opw-3322688

closes odoo#130235

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce:
- Activate "Analytic Accounting" in Accounting settings
- Go to Accounting / Configuration / Analytic Accounting / Analytic Accounts
- Create an Analytic Account with a very long name (i.e. +100 chars)
- Go to Expenses
- Create an Expense with the created Analytic Account in the Analytic field
The display of the labels in the form view should break because the badge is too
long and is taking all the available width.

Solution:
Limit the width of tag badges in "analytic_distribution" widget as it is done in "many2many_tags" widget.
https://github.com/odoo/odoo/blob/2f47df6663b65c4f6b6ec61f956c453e97563462/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.scss#L47-L49

opw-3322688

closes odoo#130235

Signed-off-by: John Laterre (jol) <[email protected]>
@MS-OSI MS-OSI requested a review from agyamuta February 17, 2025 15:13
@MS-OSI MS-OSI self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants