Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set balance below existential #1983

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

faculerena
Copy link
Contributor

@faculerena faculerena commented Nov 9, 2023

Summary

  • [M] y/n | Does it introduce breaking changes?
  • [N] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Added a check for setting the balance in tests below the existential minimum

Description

Given that accounts with a balance below the existential minimum get reaped, adding a check to prohibit setting balance below seems logical. If this should not be like this, feel free to correct us.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@faculerena faculerena force-pushed the set-balance-below-existential branch 2 times, most recently from 0e4f785 to 81a9ae9 Compare November 15, 2023 14:39
@SkymanOne
Copy link
Contributor

Please merge master

@cmichi
Copy link
Collaborator

cmichi commented Nov 6, 2024

@faculerena Could you merge master into your PR or allow me to resolve the conflicts?

@faculerena
Copy link
Contributor Author

I think its ok now @cmichi

@cmichi
Copy link
Collaborator

cmichi commented Nov 7, 2024

@faculerena There are some CI errors, do you see the Details if you click the link?

The cargo fmt issues can be applied automatically by executing cargo +nightly fmt --all locally.

@faculerena
Copy link
Contributor Author

Clippy issues fixed and fmt ran. I think the Dylint issues are the same as the other two.

@cmichi
Copy link
Collaborator

cmichi commented Nov 13, 2024

Thank you, @faculerena!

@cmichi cmichi merged commit c8f9a75 into use-ink:master Nov 13, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants