Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add basic go test coverage #100

Merged
merged 3 commits into from
Jan 29, 2025
Merged

test: add basic go test coverage #100

merged 3 commits into from
Jan 29, 2025

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jan 23, 2025

While doing a quick review on #97 I noticed there was no tests. This just adds a simple go test to a github action.

Edit: turns out, this requires a local lagoon too to run the tests against

@shreddedbacon
Copy link
Member Author

shreddedbacon commented Jan 23, 2025

This test fails currently locally because the v.Name and f.Name values are different. It seems to be replacing the f.Name with replaced

PYTHON_PIP_VERSION replaced 1 /home/.composer/vendor/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PYTHON_PIP_VERSION replaced 1 autoconf 		dpkg-dev dpkg 		file 		g++ 		gcc 		libc-dev 		make 		pkgconf 		re2c
PYTHON_PIP_VERSION replaced 1 /usr/local/etc/php

@shreddedbacon shreddedbacon marked this pull request as ready for review January 29, 2025 01:42
@shreddedbacon shreddedbacon requested a review from bomoko January 29, 2025 01:42
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. Thanks @shreddedbacon

@bomoko bomoko merged commit 36ea33b into main Jan 29, 2025
3 checks passed
@shreddedbacon shreddedbacon deleted the basic-test-coverage branch January 29, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants