Recommended fixes/changes to organizations

[DaveDarsa]

1. changes organization header gradient
2. changes various button tooltips
3. changes "view in dashboard" link
4. changes some of the placeholders
5. removes border highlight on non clickable table rows

[shreddedbacon]

The header gradient to me seems a bit off, I was initially thrown off by it when I had a quick look because I thought maybe something with the page rendered incorrectly

If the idea of the gradient is to distinguish you're in a different part of the UI for organizations, it doesn't really make it obvious

[bomoko]

A wild console.log() appears :)

[CGoodwin90]

The view user links here fail if the administator isn't in any groups in the organization. A user can be an administator but not a user/in any groups in the org. Not sure if these view user links are necessary on this page?

[DaveDarsa]

Good point, the userByEmailAndOrganization query returns null on the user page for those kind of users.
What if we have a a different view on this page if that happens?
We could also do a check in the background - if the query returns null we disable the links for those specific users?
@shreddedbacon @tobybellwood

[shreddedbacon]

That is a lot of queries to perform when rendering the page potentially, a lot of these user queries are not very cached at the moment. So performing them often could see some performance impacts over time.

If you can handle the null user experience with some sort of message that says the user is not in any groups, then that would be fine.

Alternatively, not linking the administrators of an organization to the users that are contained within the groups is also a pretty good idea.

[shreddedbacon]

I'm worried that there is going to be too much circular references in the organizations UI component that will get people clicking around and landing in all sorts of spots.

Like, the administrators of the organization are just that, and linking the user OUT of the management view into a view where they can then manage the users who are contained within the groups of the organization, which then leads them into all other parts of the management of organizations.

If I know I need to manage the organizations administrators, simplying going to manage to add, edit, or remove a user as an admin is all I should be able to do there, IMO

[shreddedbacon]

Some small issues/wording changes

---

On the manage page of the organzations UI when removing a user that has some manager level, the tooltip on the button should change from Delete user to Remove user as you aren't deleting the user from lagoon, you're removing their access to manage the organization.

Suggested wording:

This action will remove user default-user@ben-testing from management of the organization ben-test-org.

---

On the projects page of the organizations UI, when deleting a project, the message says it will delete it from the organization. This isn't entirely accurate, as it is a destructive action. The project is completely deleted from Lagoon, not just deleted from the organization.

Suggested wording?:

This action will delete project ben-testing from Lagoon and the organization.

[DaveDarsa]

@shreddedbacon @tobybellwood @CGoodwin90 I've tried numerous ways to include the <ErrorAlert /> component we use for cancelling deployment/task and in new environments.

The problem lies with either the <Mutation /> component from apollo, or react-modal that we use - multiple instances of errors get rendered; even if we limit the alert component to just one, the old instance gets destroyed and replaced with a new one, which ruins the UX.

Aside from that, I think this pr is good to go.

[tobybellwood]

Happy that this addresses the outstanding concerns