This repository has been archived by the owner on May 16, 2022. It is now read-only.
commenting on Issues/PRs with ogr #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
changed the title
release_bot/configuration.py
Outdated
| elif self.pagure_token != '' and self.pagure_username != '': | ||
| return self.get_pagure_project(username=self.pagure_username, | ||
| repository=self.repository_name, | ||
| token=self.pagure_token) |
There was a problem hiding this comment.
This PR should help you with that..;-) Feel free to add some comments. I would appreciate some opinions from the perspective of release-bot.
We can release a new version of OGR after merging that...
There was a problem hiding this comment.
There was a problem hiding this comment.
We can discuss that in #230 ...
|
@jpopelka This definitely doesn't fully implement #190, I will go through release-bot functions and make smaller PRs to complete #190. This also needs to contribute to ogr. I also deleted the test for adding a comment on Issue/PR since it is already tested in ogr. However, we will need to provided integration tests for Pagure and Github. But firstly, I assume to replace more API calls with ogr. |
| custom_instances=[ | ||
| GithubService(token=self.github_token), | ||
| PagureService(token=self.pagure_token, | ||
| instance_url=self.pagure_instance_url)]) |
rpitonak
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting on Issues and PRs are available for Github but also Pagure since now. I added two new variables into the private config file
pagure_tokenandpagure_username. I'm just thinking if we should add this into README or wait till all Github features will be implemented also for Pagure.Ogr doesn't have released commenting on issues yet. If you want to try locally you must install ogr from Github, not from requirements.txt
pip install git+https://github.com/packit-service/ogr@master