Updating optional fields in html/image/text (#40)

usewaypoint · Feb 29, 2024 · c097ba1 · c097ba1
1 parent c19d905
commit c097ba1
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 22 deletions.
diff --git a/packages/block-html/package-lock.json b/packages/block-html/package-lock.json
diff --git a/packages/block-html/package.json b/packages/block-html/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@usewaypoint/block-html",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "@usewaypoint/document compatible HTML component",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/packages/block-html/src/index.tsx b/packages/block-html/src/index.tsx
@@ -65,15 +65,15 @@ export const HtmlPropsSchema = z.object({
       color: COLOR_SCHEMA,
       backgroundColor: COLOR_SCHEMA,
       fontFamily: FONT_FAMILY_SCHEMA,
-      fontSize: z.number().min(0),
-      textAlign: z.enum(['left', 'right', 'center']).optional().nullable().default(null),
+      fontSize: z.number().min(0).optional().nullable(),
+      textAlign: z.enum(['left', 'right', 'center']).optional().nullable(),
       padding: PADDING_SCHEMA,
     })
     .optional()
     .nullable(),
   props: z
     .object({
-      contents: z.string(),
+      contents: z.string().optional().nullable(),
     })
     .optional()
     .nullable(),

diff --git a/packages/block-image/package-lock.json b/packages/block-image/package-lock.json
diff --git a/packages/block-image/package.json b/packages/block-image/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@usewaypoint/block-image",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "@usewaypoint/document compatible Image component",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/packages/block-image/src/__snapshots__/index.spec.tsx.snap b/packages/block-image/src/__snapshots__/index.spec.tsx.snap
@@ -2,9 +2,7 @@
 
 exports[`block-image renders with default values 1`] = `
 <DocumentFragment>
-  <div
-    style="text-align: center;"
-  >
+  <div>
     <img
       alt=""
       src=""

diff --git a/packages/block-image/src/index.tsx b/packages/block-image/src/index.tsx
@@ -46,7 +46,7 @@ export function Image({ style, props }: ImageProps) {
   const sectionStyle: CSSProperties = {
     padding: getPadding(style?.padding),
     backgroundColor: style?.backgroundColor ?? undefined,
-    textAlign: style?.textAlign ?? 'center',
+    textAlign: style?.textAlign ?? undefined,
   };
 
   const linkHref = props?.linkHref ?? null;

diff --git a/packages/block-text/package-lock.json b/packages/block-text/package-lock.json
diff --git a/packages/block-text/package.json b/packages/block-text/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@usewaypoint/block-text",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "@usewaypoint/document compatible Text component",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/packages/block-text/src/__snapshots__/index.spec.tsx.snap b/packages/block-text/src/__snapshots__/index.spec.tsx.snap
@@ -2,8 +2,6 @@
 
 exports[`block-text renders with default values 1`] = `
 <DocumentFragment>
-  <div
-    style="font-size: 16px;"
-  />
+  <div />
 </DocumentFragment>
 `;
diff --git a/packages/block-text/src/index.tsx b/packages/block-text/src/index.tsx
@@ -64,9 +64,9 @@ export const TextPropsSchema = z.object({
     .object({
       color: COLOR_SCHEMA,
       backgroundColor: COLOR_SCHEMA,
-      fontSize: z.number().min(0).optional().nullable(),
+      fontSize: z.number().gte(0).optional().nullable(),
       fontFamily: FONT_FAMILY_SCHEMA,
-      fontWeight: z.enum(['bold', 'normal']).nullable(),
+      fontWeight: z.enum(['bold', 'normal']).optional().nullable(),
       textAlign: z.enum(['left', 'center', 'right']).optional().nullable(),
       padding: PADDING_SCHEMA,
     })
@@ -90,7 +90,7 @@ export function Text({ style, props }: TextProps) {
   const wStyle: CSSProperties = {
     color: style?.color ?? undefined,
     backgroundColor: style?.backgroundColor ?? undefined,
-    fontSize: style?.fontSize ?? 16,
+    fontSize: style?.fontSize ?? undefined,
     fontFamily: getFontFamily(style?.fontFamily),
     fontWeight: style?.fontWeight ?? undefined,
     textAlign: style?.textAlign ?? undefined,
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,9 +2,7 @@ @@
     exports[`block-image renders with default values 1`] = `
     <DocumentFragment>
-      <div
-        style="text-align: center;"
-      >
+      <div>
         <img
           alt=""
           src=""
@@ Expand Down @@