Fix logging error #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to ingress.class annotation
* This made it easier for us to get the project up and running and testing out different types of ingress definitions etc.
Support networking.k8s.io ingresses
fix null pinter issue
Dynamic discovery ingress IPs
Upgrade protobuf envoy
Smart route translation
Co-authored-by: Joonas Köppä <[email protected]>
fix class error message
Co-authored-by: Joonas Köppä <[email protected]>
Co-authored-by: Joonas Köppä <[email protected]>
remove messagetostruct to use envoy protobuf message
add sorted list and only use of pointer when its needed
|
Whoopsie, wrong base repo :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing because logrus doesn't like formatting options in the error message strings - this format is recommended in their documentation