Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable upstream timeouts #85

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Aluxima
Copy link
Contributor

@Aluxima Aluxima commented Jul 4, 2024

Hi, this feature adds the possibility to customize specific upstream timeouts, both with default values and via ingress annotations.

This brings no breaking change, the old timeout parameter still has the same behavior.

Thanks :)

SoulKyu and others added 7 commits July 3, 2024 10:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
The new annotations got the priority, the simple 'timeout' annotation still sets the 3 timeouts but if there is, at least one of the new ones, it's overwriting the values set by the simple annotation.
Applying @Aluxima suggestion

Co-authored-by: Laurent Marchaud <[email protected]>
@SoulKyu
Copy link
Contributor

SoulKyu commented Nov 15, 2024

@mmcgarr hello, any news on this issue ? :)

@mmcgarr
Copy link
Contributor

mmcgarr commented Dec 23, 2024

Hi @Aluxima thanks for making this change! Can you just rebase on master and I'll be able to get this merged in 🙏

@@ -1,3 +1,7 @@
bin/
command
testing
ca/
config/
envoy/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignores all directories called envoy, including pkg/envoy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants