Correctly remove prom metrics #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Marchaud <[email protected]>
The new annotations got the priority, the simple 'timeout' annotation still sets the 3 timeouts but if there is, at least one of the new ones, it's overwriting the values set by the simple annotation.
Applying @Aluxima suggestion Co-authored-by: Laurent Marchaud <[email protected]>
Signed-off-by: Laurent Marchaud <[email protected]>
Signed-off-by: Laurent Marchaud <[email protected]>
Signed-off-by: Laurent Marchaud <[email protected]>
… domain different than the our ingress
Signed-off-by: Laurent Marchaud <[email protected]>
* remove healthcheck for bad configure ingress with wildcard * fix: reorder code for a more comprehensive way
* remove healthcheck for bad configure ingress with wildcard * feat: add a way to configure log path
Signed-off-by: Laurent Marchaud <[email protected]>
* Add a feature to handle maintenance mode on yggdrasil * Add a metrics with upstream informations to join with kube ingress metrics
…ctly from the metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually metrics are added be never deleted even if the ingress is deleted, we should restart yggdrasil when we wan't our metrics to be correctly updated (only for the deleted one)
All explained here : https://gitlab.numberly.in/team-infrastructure/infrastructure/-/issues/703