stty: fix negated operands

[andrewliebenow]

Also: use correct file descriptor (stdin) to look up tty
Also: fix handling of end of options delimiter ("--")
Also: use StdoutLock for printing

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/tail/assert is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[sylvestre]

if it is generated at build time, does it need to be in tree ?

and if the answer is yes, could you please add a comment on top of this file to explain what it is, thanks

[sylvestre]

@andrewliebenow ping ? :)

[sylvestre]

Ping? :)

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/misc/stdbuf. tests/misc/stdbuf is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

[tertsdiepraam]

Nice PR! I'd suggest splitting this up a bit to make it easier for review. I'd also prefer trying an implementation without phf first, so that we can make a properly benchmarked decision on whether phf is worth it in this case. Adding build scripts and generated files is usually a bit of a hassle and hard for incremental compilation.

(I'm not really involved with the project much anymore and mostly chiming in as the author of stty. The other maintainers' feedback is much more important)