Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLAS] Add BLAS ARM performance libraries backend. #629

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

adegomme
Copy link

Description

This adds the support for aarch64 CPUs using ARM performance libraries backend, with BLAS domain for now (LAPACK to come later).
Support for most functions is native, some batch ones are implemented directly.
It also enables NETLIB backend on aarch64 CPUs.

  • Do all unit tests pass locally?
    This has been tested on Neoverse N1, V1, V2 CPUs, with dpcpp compiler and pocl backend.
    100% tests passed, 0 tests failed out of 1960
    128 tests are skipped, due to unimplemented omatadd/copy, batch or int8/bfloat16 unsupported features.
    AdaptiveCpp also has been tested to compile and run.
    log.txt

Signed-off-by: Augustin Degomme <[email protected]>
Co-authored-by: Nicolas Bouton <[email protected]>
Co-authored-by: Romain Dolbeau <[email protected]>
@adegomme adegomme requested review from a team as code owners January 28, 2025 10:59
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! I have a few initial comments/questions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/building_the_project_with_dpcpp.rst Outdated Show resolved Hide resolved
src/blas/backends/armpl/armpl_common.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

tests/unit_tests/main_test.cpp Outdated Show resolved Hide resolved
src/blas/backends/armpl/CMakeLists.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just to double-check: you have tested both the Netlib backend and the Arm Performance Libraries backend on ARM hardware?

@adegomme
Copy link
Author

Looks good! Just to double-check: you have tested both the Netlib backend and the Arm Performance Libraries backend on ARM hardware?

Indeed, see log attached for the netlib one (on an ARM neoverse v2 platform)
log_netlib.txt
(more tests are skipped as there are more unimplemented calls)

@dnhsieh-intel
Copy link
Contributor

It looks like some tables are off:

image

image

Please update the tables. Thanks!

@adegomme
Copy link
Author

adegomme commented Jan 29, 2025

It looks like some tables are off:

Please update the tables. Thanks!

good catch, it shoud be fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants