Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update geolocation-cn #25

Merged
merged 6 commits into from
Jul 21, 2020
Merged

Update geolocation-cn #25

merged 6 commits into from
Jul 21, 2020

Conversation

IceCodeNew
Copy link
Collaborator

No description provided.

@EpLiar
Copy link
Member

EpLiar commented Jul 20, 2020

  1. boc shouldn't be in abchina.
  2. The IP address of tuna.moe is not in China and there is no ICP record at the bottom of the page. This one needs to be discussed.
  3. Same to mokeedev. It uses CloudFlare's CDN.

@IceCodeNew
Copy link
Collaborator Author

  1. boc shouldn't be in abchina.

不明白你想表达什么意思，中国银行相关的域名我都是直接从原来的 geolocation-cn 移动过去的，我 dig 了一遍没看出哪里有问题

  • The IP address of tuna.moe is not in China and there is no ICP record at the bottom of the page. This one needs to be discussed.
  • Same to mokeedev. It uses CloudFlare's CDN.

Fixed.

@EpLiar
Copy link
Member

EpLiar commented Jul 20, 2020

不明白你想表达什么意思，中国银行相关的域名我都是直接从原来的 geolocation-cn 移动过去的，我 dig 了一遍没看出哪里有问题

abchina 全称是中国农业银行，boc 是中国银行。既然原来的有问题在你搬运的时候就顺手修一下吧。

@IceCodeNew
Copy link
Collaborator Author

不明白你想表达什么意思，中国银行相关的域名我都是直接从原来的 geolocation-cn 移动过去的，我 dig 了一遍没看出哪里有问题

abchina 全称是中国农业银行，boc 是中国银行。既然原来的有问题在你搬运的时候就顺手修一下吧。

噗嗤，懂了。我都没发现这个问题（

@Loyalsoldier
Copy link
Collaborator

Please rebase branch.

@IceCodeNew
Create category-bank-cn
78759a0 
0. Move icbc
1. Move Bank of China
2. Move unionpay
@IceCodeNew
Create category-collaborate-cn
fbd663d 
0. Add shimo.im
1. Add yuque.com
@IceCodeNew
Create category-hospital-cn
3d30992 
0. Add fuwai.com
1. Add pkuh6.cn
2. Add puh3.net.cn
3. Add hospital.pku.edu.cn
4. Add ss.bjmu.edu.cn
@IceCodeNew
Create category-mooc-cn
a4ff223 
0. Add chinesemooc.org
1. Add cnmooc.org
2. Add icourse163.org
3. Add icourses.cn
4. Add mooc.cn
5. Add openlearning.com
6. Add pmphmooc.com
7. Add moocs.unipus.cn
8. Add opencourse.pku.edu.cn
9. Add study.163.com
@IceCodeNew
Create category-wiki-cn
3e6ebcb 
0. Add huijistatic.com
1. Add huijiwiki.com
2. Add moegirl.org
@IceCodeNew
Update geolocation-cn
6bbccda 
0. Add guoxuedashi.com, guoxuemi.com;
1. Add haidilao.com
@IceCodeNew
Copy link
Collaborator Author

Please rebase branch.

Done.

@EpLiar EpLiar merged commit c160fe1 into v2fly:master Jul 21, 2020
@Loyalsoldier
Copy link
Collaborator

@IceCodeNew

Please keep adding domains and updating the categories you create in this PR since it's a bit abuse of category here. I think a category should be "big" and "rich", or don't create it.

@IceCodeNew IceCodeNew mentioned this pull request Jul 21, 2020
Open
@IceCodeNew
Copy link
Collaborator Author

@IceCodeNew

Please keep adding domains and updating the categories you create in this PR since it's a bit abuse of category here. I think a category should be "big" and "rich", or don't create it.

你说的有道理，很多新创建的分类我也就是起个头，之后应该要继续把 geolocation-cn 里没有得到分类的域名搬进去。
顺便关于未来 geolocation-cn 里历史数据和新数据的发展方向，我也有些想法，不知道你是否可以来 Issue #28 讨论。
@Loyalsoldier

@IceCodeNew IceCodeNew deleted the 4pr_update_geolocation-cn branch July 21, 2020 06:55
@Robot-DaneelOlivaw
Copy link
Contributor

geolocation-cn should keep same structure as geolocation-!cn using comment. I don't think there's necessity to create these lists.

@IceCodeNew IceCodeNew mentioned this pull request Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpLiar EpLiar EpLiar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IceCodeNew @EpLiar @Loyalsoldier @Robot-DaneelOlivaw