Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple & google direct list #89

Closed
wants to merge 4 commits into from
Closed

Add apple & google direct list #89

wants to merge 4 commits into from

Conversation

Loyalsoldier
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Robot-DaneelOlivaw Robot-DaneelOlivaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite like the idea of @direct, mostly because of the name. It's implying that these domains shouldn't be proxied.

Maybe combine with @cn? Since we have tld-cn, there's no need to distinguish .cn with attribute. If so, list name should be renamed too.

@IceCodeNew
Copy link
Collaborator

I don't quite like the idea of @direct, mostly because of the name. It's implying that these domains shouldn't be proxied.

附议。

Copy link
Member

@DuckSoft DuckSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use opinionated names like 'direct'.

@Loyalsoldier Loyalsoldier marked this pull request as draft July 28, 2020 04:16
@Loyalsoldier
Copy link
Collaborator Author

I would like to implement this first: #88 (comment)

Mark this PR as draft for now.

@Robot-DaneelOlivaw
Copy link
Contributor

The lists are worth adding in my opinion. We just need to find a proper name for them. I reckon @cn would be fine. Personally, I prefer adding them directly in data/apple and data/google instead of creating new lists.

Also, are we going to maintain this kind of lists for every company? Or just Apple and Google?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants