-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apple & google direct list #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite like the idea of @direct
, mostly because of the name. It's implying that these domains shouldn't be proxied.
Maybe combine with @cn
? Since we have tld-cn
, there's no need to distinguish .cn
with attribute. If so, list name should be renamed too.
附议。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use opinionated names like 'direct'.
I would like to implement this first: #88 (comment) Mark this PR as draft for now. |
The lists are worth adding in my opinion. We just need to find a proper name for them. I reckon Also, are we going to maintain this kind of lists for every company? Or just Apple and Google? |
No description provided.