-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
Reviewed 1 of 1 files at r1. Comments from Reviewable |
In order for the |
@mvysny oh, Thanks for that.. I will remove that now. from the browser console, in fact, the annotation will overright the setting in the |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
Thanks @ZheSun88 ! Now the problem is that Beverage Buddy was designed with wrap height; changing that to 100vh requires redesign of all layouts... And that's quite a hell of a work. I'm trying to do that and I'm hitting some bugs - e.g. Grid being always taller than required. |
@mvysny from my side, everything still looks fine and all the layouts are still well designed .. maybe i should verify it with others.. |
It looks fine, that is correct. However, if you notice the div (or rather vertical layout) containing the list of Reviews, it now overflows the body element. I don't think this is a good CSS practice, or is it? |
@mvysny Oh, i see the ugly horizontal scrollbar now.. Thanks for noticing that..I will try to fix it |
a separate ticket about the scrollbar is created. #147 |
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)