Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Apply BodySize #145

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Apply BodySize #145

merged 2 commits into from
Jan 9, 2018

Conversation

ZheSun88
Copy link
Collaborator

@ZheSun88 ZheSun88 commented Jan 9, 2018

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2018

CLA assistant check
All committers have signed the CLA.

@ZheSun88 ZheSun88 requested a review from caalador January 9, 2018 12:37
@denis-anisimov
Copy link

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mvysny
Copy link
Member

mvysny commented Jan 9, 2018

In order for the @BodySize annotation to be effective, you first need to remove the height: auto; applied to body from the styles.html file.

@ZheSun88
Copy link
Collaborator Author

ZheSun88 commented Jan 9, 2018

@mvysny oh, Thanks for that.. I will remove that now.

from the browser console, in fact, the annotation will overright the setting in the styles.html. could you verify?

@denis-anisimov
Copy link

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mvysny
Copy link
Member

mvysny commented Jan 9, 2018

Thanks @ZheSun88 ! Now the problem is that Beverage Buddy was designed with wrap height; changing that to 100vh requires redesign of all layouts... And that's quite a hell of a work. I'm trying to do that and I'm hitting some bugs - e.g. Grid being always taller than required.

@ZheSun88
Copy link
Collaborator Author

ZheSun88 commented Jan 9, 2018

@mvysny from my side, everything still looks fine and all the layouts are still well designed .. maybe i should verify it with others..

@mvysny
Copy link
Member

mvysny commented Jan 9, 2018

It looks fine, that is correct. However, if you notice the div (or rather vertical layout) containing the list of Reviews, it now overflows the body element. I don't think this is a good CSS practice, or is it?

@ZheSun88
Copy link
Collaborator Author

ZheSun88 commented Jan 9, 2018

@mvysny Oh, i see the ugly horizontal scrollbar now.. Thanks for noticing that..I will try to fix it

@ZheSun88 ZheSun88 merged commit 16a57b2 into master Jan 9, 2018
@ZheSun88 ZheSun88 deleted the Zhe-Apply-bodysize branch January 9, 2018 14:44
@ZheSun88
Copy link
Collaborator Author

a separate ticket about the scrollbar is created. #147

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants