Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud): use noNewButton name and fix form visibility #3326

Conversation

cromoteca
Copy link
Contributor

Changes the recently introduced newButton property to noNewButton and hides the empty form when the new property is true.

Fixes #3324

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (df94354) to head (82fdd00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3326   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         115      115           
  Lines        8287     8289    +2     
  Branches     1269     1271    +2     
=======================================
+ Hits         7201     7203    +2     
  Misses       1072     1072           
  Partials       14       14           
Flag Coverage Δ
unittests 86.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cromoteca cromoteca requested a review from Lodin March 6, 2025 10:15
Copy link

sonarqubecloud bot commented Mar 6, 2025

@Lodin Lodin merged commit e18e89c into main Mar 6, 2025
16 checks passed
@Lodin Lodin deleted the 3324/New-item-form-in-AutoCrud-remains-enabled-even-if-the-New-button-is-hidden branch March 6, 2025 10:36
Lodin pushed a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New item form in AutoCrud remains enabled even if the New button is hidden
4 participants