Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly simplifies React wrapper generation; instead of TypeScript AST, it uses plain strings which improves the readability of the code. The code has been reduced by more than half as well. TypeScript is still used for catching syntax errors and apply common style in generated files; though, we can remove this step if needed.
Also, the generator script drops the customfswalk
andfromAsync
functions in favor of the nativeglob
(it is experimental but since it is our internal script I consider it ok). However, this change requires Node v22 LTS.Since there are two packages managed by a root
tsconfig
, andglob
needs newer TS libs, I had to switch the root toesnext
. To keep packages ones2021
, I created separatetsconfig.json
files for each package. So, now, we can usees2021
for packages and use any modern stuff in our scripts.EDIT:
Since I faced an issue in vaadin/hilla repo (we use Node v20 instead of Node v22 for building Vaadin 24.x, and going to move to Node v22 only in Vaadin 25), I decided to replace the native
glob
with the similar implementation from thenode-glob
package. I have also replaced all the obsolete utils (fswalk
andfromAsync
) with theglob
, which revealed a minor error in thepackage.json
update (deeply nested CSS folders were not visited and put into thepackage.json
).