feat: allow adding custom data to menu bar item types #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
force-pushed
the
feat/menu-bar-custom-item-type
branch
from
4a64f1e to
90f35c5
Compare
web-padawan
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
MenuBarandMenuBarItemtypes generic so that:MenuBarItemaccepts a type for custom item data, so that you can easily create custom item typesMenuBaraccepts a custom item type, which restricts the items that can be set, and provides that type in theitem-selectedeventPart of vaadin/web-components#8700
Depends on vaadin/web-components#8698
Type of change