refactor: remove unused internal mixin detection property (#6928)

vaadin · Dec 7, 2023 · a5fd954 · a5fd954
1 parent 1fb3395
commit a5fd954
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/packages/a11y-base/src/list-mixin.d.ts b/packages/a11y-base/src/list-mixin.d.ts
@@ -15,11 +15,6 @@ export declare function ListMixin<T extends Constructor<HTMLElement>>(
 ): Constructor<KeyboardDirectionMixinClass> & Constructor<KeyboardMixinClass> & Constructor<ListMixinClass> & T;
 
 export declare class ListMixinClass {
-  /**
-   * Used for mixin detection because `instanceof` does not work with mixins.
-   */
-  _hasVaadinListMixin: boolean;
-
   /**
    * If true, the user cannot interact with this element.
    * When the element is disabled, the selected item is

diff --git a/packages/a11y-base/src/list-mixin.js b/packages/a11y-base/src/list-mixin.js
@@ -20,14 +20,6 @@ export const ListMixin = (superClass) =>
   class ListMixinClass extends KeyboardDirectionMixin(superClass) {
     static get properties() {
       return {
-        /**
-         * Used for mixin detection because `instanceof` does not work with mixins.
-         * @type {boolean}
-         */
-        _hasVaadinListMixin: {
-          value: true,
-        },
-
         /**
          * If true, the user cannot interact with this element.
          * When the element is disabled, the selected item is

diff --git a/packages/list-box/test/list-box.test.js b/packages/list-box/test/list-box.test.js
@@ -4,7 +4,7 @@ import '@vaadin/item/vaadin-item.js';
 import '../vaadin-list-box.js';
 
 describe('vaadin-list-box', () => {
-  let listBox;
+  let listBox, tagName;
 
   beforeEach(() => {
     listBox = fixtureSync(`
@@ -13,9 +13,14 @@ describe('vaadin-list-box', () => {
         <vaadin-item>Bar</vaadin-item>
       </vaadin-list-box>
     `);
+    tagName = listBox.tagName.toLowerCase();
   });
 
-  it('should extend list-mixin', () => {
-    expect(listBox._hasVaadinListMixin).to.be.true;
+  it('should be defined in custom element registry', () => {
+    expect(customElements.get(tagName)).to.be.ok;
+  });
+
+  it('should have a valid static "is" getter', () => {
+    expect(customElements.get(tagName).is).to.equal(tagName);
   });
 });