Fix potential infinite recursion error #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, unfortunately, I don't have the example sentence that originates this, as I couldn't log it. I just managed to see the stack trace of a |
|
Thank you for contributing. I merged the PR, but I am still interested in learning under what scenario that happens... |
|
Yeah, honestly me too haha. But my program crashed with this stack trace (infinitely recursing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that some spaCy docs have cycles in their "compounds" dependencies, in the dependency graph. It's very unlikely (in my estimates, it's about 1 in 60 million sentences that I tried) but it seems to be plausible. So it's better to avoid crashing. I fix it in this PR