New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the pronoun filter error; fix relation with "is" as AUX; make __flatten_conjunction recursive #27

Merged

vacancy merged 3 commits into vacancy:master from pzzhang:master

Jan 22, 2024

Contributor

pzzhang commented Jan 22, 2024

The pronoun filter "entity.root.lemma_ == '-PRON-'" is out of date. Fixed it.
Deal with error cases: "A woman is in front of a piano." and "A woman is next to a piano."
__flatten_conjunction should be recursive to get all conjunctions. Fixed it with example "A bowl of rice, noodle and grains."

pzzhang added 3 commits

January 22, 2024 08:33


          update parser and test examples

ab4be2e


          Merge pull request #1 from pzzhang/fix_pronoun_and_of

a29c8c1

update parser and test examples


          Minor update for the case "A piano is next to a woman"

73f1176

vacancy merged commit 3aa8a51 into vacancy:master

Owner

vacancy commented Jan 22, 2024

Thank you for contributing!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet