Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Indonesia holidays: add 2024 Local Election, exact historic dates from 1963 onwards #2102

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Nov 2, 2024

Proposed change

  • Add Nov 27, 2024 as Local Election Day - while this doesn't have a Presidential Decree (Keputusan Presiden/Keppress) yet, "PANRB Minister Abdullah Azwar Anas said the 2024 Regional Election holiday would be further regulated in the Presidential Regulation"
  • Add Jan 2, 2017 as a "New Year's Joint Holiday" as per listed here.
  • Remove Dec 24, 2021 ("Christmas Joint Holiday") from the list as it's indeed marked as abolished here.
  • Add the exact historic date assignment for Islamic holidays, Nyepi, and Vesak day from 1963 onwards as listed here.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aba7b09) to head (c714a8e).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11563     11563           
  Branches      1739      1739           
=========================================
  Hits         11563     11563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this in!

Thanks @PPsyrius

tests/countries/test_indonesia.py Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Nov 4, 2024
Merged via the queue into vacanza:dev with commit bf30cb2 Nov 4, 2024
27 of 28 checks passed
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
@PPsyrius PPsyrius deleted the id_nyepi branch November 5, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants