Add index property to Transform
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to know which line is being transformed. Fix: vadimdemedes#611
|
Pushed a commit that fixes all lint errors, and most of the warnings. I didn't feel confident reducing parameter counts or indent levels, since that's a more involved refactoring than just running |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to know which line is being transformed.
Fix: #611
There are some linting errors, but I'm not sure how to go about fixing them.
for(;;)(or maybe.forEach()) is the right thing to use here, since the index is relevant, but xo really wants to only ever seefor(of).