Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug has been introduced with the work done here and it relates to the tokenization of ansi escape characters. We noticed it with
ansiEscapes.link
and I added a test case in this repo which now fails.@AlCalzone I don't know enough about your
ansi-tokenize
project, but could this be fixed there?Here's a screenshot of the failing test:
You can see from the screenshot that the link escape is not being closed properly so the link "leaks" in all the text after that.