Fix argument types of formatting functions #1253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtSin
force-pushed
the
fix-format-arg-types
branch
from
4cfef26
to
9352768
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1253 +/- ##
============================================
- Coverage 70.70% 70.68% -0.02%
============================================
Files 114 114
Lines 63157 63158 +1
============================================
- Hits 44653 44644 -9
- Misses 18504 18514 +10
|
madolson
reviewed
Nov 4, 2024
deps/lua/src/lua_cjson.c
Outdated
| @@ -1131,7 +1131,7 @@ static void json_decode_descend(lua_State *l, json_parse_t *json, int slots) | |||
|
|
|||
| strbuf_free(json->tmp); | |||
| luaL_error(l, "Found too many nested data structures (%d) at character %d", | |||
| json->current_depth, json->ptr - json->data); | |||
| json->current_depth, (int)(json->ptr - json->data)); | |||
There was a problem hiding this comment.
I would rather leave lua alone if we can.
There was a problem hiding this comment.
yeah, I know, but it's a vendored dependency and we would prefer it stay as it is upstream.
`cluster_legacy.c`: `slot_info_pairs` has `uint16_t` values, but they were cast to `unsigned long` and `%i` was used. `valkey-cli.c`: `node->replicas_count` is `int`, not `unsigned long`. Signed-off-by: ArtSin <[email protected]>
ArtSin
force-pushed
the
fix-format-arg-types
branch
from
9352768
to
e78d9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster_legacy.c:slot_info_pairshasuint16_tvalues, but they were cast tounsigned longand%iwas used.valkey-cli.c:node->replicas_countisint, notunsigned long.