Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reply schema for LATENCY-LATESTS new fields #1678

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

enjoy-binbin
Copy link
Member

These fields was added in #224.

These fields was added in valkey-io#224.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin
Copy link
Member Author

This also fix the reply daily:

JSON schema validation error on /home/runner/work/valkey/valkey/tests/tmp/server.7213.155/stdout.reqres: ['command', 1738801393, 716, 716, 716, 1] is too long

Failed validating 'maxItems' in schema['items']:
    {'items': [{'description': 'Event name.', 'type': 'string'},
               {'description': 'Timestamp.', 'type': 'integer'},
               {'description': 'Latest latency in milliseconds.',
                'type': 'integer'},
               {'description': 'Max latency in milliseconds.',
                'type': 'integer'}],
     'maxItems': 4,
     'minItems': 4,
     'type': 'array'}

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (110dd55) to head (7bda2f4).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1678   +/-   ##
=========================================
  Coverage     71.05%   71.05%           
=========================================
  Files           121      121           
  Lines         65243    65243           
=========================================
+ Hits          46358    46359    +1     
+ Misses        18885    18884    -1     

see 13 files with indirect coverage changes

Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Binbin <[email protected]>
@zuiderkwast zuiderkwast merged commit 0579103 into valkey-io:unstable Feb 6, 2025
51 of 60 checks passed
@enjoy-binbin enjoy-binbin deleted the add_latency_reply branch February 7, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants