-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect assertion in client list operations #1800
Open
uriyage
wants to merge
5
commits into
valkey-io:unstable
Choose a base branch
from
uriyage:fix-wrong-assert
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug where using &pointer.next would always be non-NULL - Replace always-true assertion that used &pointer with actual list membership check - Add proper assertion in listUnlinkNode to ensure list length > 0 Signed-off-by: Uri Yagelnik <[email protected]>
2bc0ecd
to
d81b411
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1800 +/- ##
============================================
- Coverage 71.17% 71.00% -0.18%
============================================
Files 123 123
Lines 65648 65655 +7
============================================
- Hits 46724 46617 -107
- Misses 18924 19038 +114
|
zuiderkwast
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Small comment though.
Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: uriyage <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: uriyage <[email protected]>
Signed-off-by: Uri Yagelnik <[email protected]>
Signed-off-by: Uri Yagelnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current assertion introduced in redis/redis#11220
is incorrect for two reasons:
Fix: