Add support for setting the group on a unix domain socket #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @madolson can you please take a look? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #901 +/- ##
============================================
- Coverage 70.40% 70.33% -0.07%
============================================
Files 112 112
Lines 61465 61518 +53
============================================
- Hits 43275 43271 -4
- Misses 18190 18247 +57
|
madolson
reviewed
Aug 13, 2024
madolson
reviewed
Aug 13, 2024
ayush933
force-pushed
the
unixSocketGroup
branch
from
895c1ad to
9bfd70e
Compare
|
Addressed reviews and added UT to test that permissions are set correctly. |
ayush933
force-pushed
the
unixSocketGroup
branch
2 times, most recently
from
33e2274 to
f0839bd
Compare
madolson
reviewed
Aug 16, 2024
ayush933
force-pushed
the
unixSocketGroup
branch
from
f0839bd to
aa7526e
Compare
ayush933
force-pushed
the
unixSocketGroup
branch
from
aa7526e to
e5a9ae3
Compare
madolson
reviewed
Aug 19, 2024
ayush933
force-pushed
the
unixSocketGroup
branch
from
e5a9ae3 to
30b0685
Compare
|
@valkey-io/core-team Please vote on this small feature, we can optionally include it in Valkey 8.0 if it's ready for rc2, but not after. |
enjoy-binbin
approved these changes
Aug 20, 2024
Add new optional, immutable string config called unixsocketgroup. Change the group of the unix socket to unixsocketgroup after bind() if specified. Signed-off-by: Ayush Sharma <[email protected]>
ayush933
force-pushed
the
unixSocketGroup
branch
from
30b0685 to
c8aeaae
Compare
hwware
reviewed
Aug 21, 2024
madolson
approved these changes
Aug 21, 2024
madolson
added
release-notes
|
Since the new test is a bit odd, running the daily against a bunch of different platforms. https://github.com/valkey-io/valkey/actions/runs/10530596918 |
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
Add new optional, immutable string config called `unixsocketgroup`. Change the group of the unix socket to `unixsocketgroup` after `bind()` if specified. Adds tests to validate the behavior. Fixes #873. Signed-off-by: Ayush Sharma <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
Add new optional, immutable string config called `unixsocketgroup`. Change the group of the unix socket to `unixsocketgroup` after `bind()` if specified. Adds tests to validate the behavior. Fixes #873. Signed-off-by: Ayush Sharma <[email protected]>
lilpoozie2005
approved these changes
Sep 11, 2024
pizhenwei
added a commit
to pizhenwei/valkey
that referenced
this pull request
Oct 13, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <[email protected]> Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
added a commit
to pizhenwei/valkey
that referenced
this pull request
Oct 13, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <[email protected]> Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
added a commit
to pizhenwei/valkey
that referenced
this pull request
Oct 13, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <[email protected]> Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
added a commit
to pizhenwei/valkey
that referenced
this pull request
Oct 13, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <[email protected]> Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
added a commit
to pizhenwei/valkey
that referenced
this pull request
Oct 18, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <[email protected]> Signed-off-by: zhenwei pi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new optional, immutable string config called
unixsocketgroup.Change the group of the unix socket to
unixsocketgroupafterbind()if specified.Manually verified that group is modified as expected and fails on illegal arguments (like non existent group name).
Fixes #873.