Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query string passthrough #6

Merged
merged 3 commits into from
May 31, 2021
Merged

Query string passthrough #6

merged 3 commits into from
May 31, 2021

Conversation

akx
Copy link
Member

@akx akx commented May 28, 2021

This PR addresses the querystring mutilation part of #3:

  • The default get_upstream_http_options() implementation no longer sets params.
  • Instead, it calls the new get_upstream_url_with_query function whose default implementation appends the verbatim client querystring to whatever the user-defined get_upstream_url() function returns.

cc @jokull – would you like to take a look at the implementation? I think this shouldn't break your current code either.

@akx akx added the enhancement New feature or request label May 28, 2021
@akx akx requested review from a team, ruksi and magdapoppins and removed request for a team May 28, 2021 07:25
Copy link

@jokull jokull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx akx marked this pull request as ready for review May 28, 2021 07:35
@akx akx force-pushed the qs-passthrough branch from 825ce6b to ef4048d Compare May 28, 2021 08:06
@akx akx mentioned this pull request May 28, 2021
@akx akx force-pushed the qs-passthrough branch from ef4048d to d7c6394 Compare May 28, 2021 08:31
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less params, more new and shiny get_upstream_url_with_query and no more over-massaging of URL query strings

and the header fiddling left as an exercise for another day 👍

lgtm 🚢

@ruksi ruksi merged commit e5f71d0 into master May 31, 2021
@ruksi ruksi deleted the qs-passthrough branch May 31, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants