-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): fixed inline datepicker subscriptions #6339
Conversation
Visit the preview URL for this PR (updated for commit b5db1c4): https://ngx-bootstrap-demo--pr6339-fix-datepicker-subsc-0zv35txm.web.app (expires Tue, 18 Jan 2022 12:30:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Codecov Report
@@ Coverage Diff @@
## development #6339 +/- ##
===============================================
+ Coverage 75.86% 75.91% +0.05%
===============================================
Files 344 315 -29
Lines 10777 10638 -139
Branches 2547 2933 +386
===============================================
- Hits 8176 8076 -100
+ Misses 2591 2561 -30
+ Partials 10 1 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsubscribe should be in all versions I suppose
if (this._subs?.length) { | ||
this._subs.map(sub => sub.unsubscribe()); | ||
} | ||
this._subs = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._subs = []; |
fix(datepicker): fixed inline datepicker subscriptions
close #6263
What to test:
In inline datepicker and daterangepicker was fixed subscriptions
Preconditions:
use local version from this branch for reproducing this fix from issue
How to test:
on local version try reproducing as in issue example