Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor queries to ensure order direction in ListAgents, ListComponents, and ListServices #33

Merged
merged 9 commits into from
Jun 15, 2024
Merged

Refactor queries to ensure order direction in ListAgents, ListComponents, and ListServices #33

merged 9 commits into from
Jun 15, 2024

Conversation

truemiller
Copy link
Collaborator

Proposed changes

Update order direction to desc for Components, Agents, Services.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 3:15pm
govern ❌ Failed (Inspect) Jun 14, 2024 3:15pm
launch ❌ Failed (Inspect) Jun 14, 2024 3:15pm
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 3:15pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 3:15pm

mohandast52
mohandast52 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add an indication (down arrow maybe?) that it is sorted in descending order? For other chains, it is ascending.

Sl

@truemiller
Copy link
Collaborator Author

down arrow maybe

good catch, I hadn't noticed this on other chains. will see what's causing this.
currently ticket is just to sort by 'desc', happy to make this dynamic so user can click on the header, thoughts here @oaksprout?

@truemiller truemiller changed the title Refactor queries to include order direction in ListAgents, ListComponents, and ListServices (WIP) Refactor queries to include order direction in ListAgents, ListComponents, and ListServices Jun 13, 2024
@truemiller truemiller changed the title (WIP) Refactor queries to include order direction in ListAgents, ListComponents, and ListServices Refactor queries to ensure order direction in ListAgents, ListComponents, and ListServices Jun 14, 2024
oaksprout
oaksprout approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@oaksprout oaksprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested. Looks good.

@truemiller truemiller merged commit 917c28d into main Jun 15, 2024
4 of 8 checks passed
@mohandast52 mohandast52 deleted the josh/registry-graph-sort-desc branch June 18, 2024 21:08
@oaksprout oaksprout mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@oaksprout oaksprout oaksprout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@truemiller @mohandast52 @Tanya-atatakai @oaksprout