(govern) fix: update state after voting, fix rollover pool sorting, a… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tanya-atatakai
force-pushed
the
tanya/govern-fixes
branch
from
f4ce78d to
13879ae
Compare
…dd next week explanation
Tanya-atatakai
force-pushed
the
tanya/govern-fixes
branch
from
13879ae to
e693e40
Compare
mohandast52
approved these changes
Aug 1, 2024
kupermind
approved these changes
Aug 1, 2024
oaksprout
requested changes
Aug 1, 2024
| @@ -218,7 +219,8 @@ export const EditVotes = ({ allocations, setAllocations, setIsUpdating }: EditVo | |||
| /> | |||
|
|
|||
| <Paragraph type="secondary" className="text-end"> | |||
| New voting weight will take effect at the beginning of the next week. | |||
| Updated voting weights will take effect at the start of | |||
There was a problem hiding this comment.
Updated voting weights will take effect at the start of next week (according to Unix time). <Tooltip>Learn more</Tooltip>
There was a problem hiding this comment.
Talked to Roman and we agreed to remove the tooltip with the link from this state (where we are editing votes but haven't voted yet) because if no one voted during the week, the link would show an incorrect value, which might be confusing. So we just keep the text "Updated voting weights will take effect at the start of next week (according to Unix time). "
Tanya-atatakai
force-pushed
the
tanya/govern-fixes
branch
from
bf3f61c to
1321d5b
Compare
oaksprout
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply