-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(govern) feat: migrate veOlas to govern #74
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
51ce62a
to
45e29f9
Compare
45e29f9
to
0e15424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the functionality I could – it's working well.
I wasn't able to test the claiming logic because it will take 1 week, but on the 15th I'll be able to test it.
apps/govern/components/VeOlas/IncreaseLockModal/IncreaseAmount.tsx
Outdated
Show resolved
Hide resolved
apps/govern/components/VeOlas/IncreaseLockModal/IncreaseUnlockTime.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, a few minor pointers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added minor suggestions
0dc41fc
to
ee62e16
Compare
ee62e16
to
7585197
Compare
Fixes
Migrates veOlas page from members app to govern with some fixes below:
Create lock:
Screen.Recording.2024-08-07.at.21.45.39.mov
Increase Amount:
Screen.Recording.2024-08-07.at.21.46.19.mov
Increase unlock time
Screen.Recording.2024-08-07.at.21.48.10.mov
Claim view
Wallet not connected view
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply