Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(govern) feat: migrate veOlas to govern #74

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Aug 7, 2024

Fixes

Migrates veOlas page from members app to govern with some fixes below:

  1. There were duplicate calls (different getters, but in the contract they use one another) - fixed that
  2. There were extra approve OLAS requests (e.g. when increasing lock it's not needed, we don't change the amount), or approve was requested not for the entered value but for the whole OLAS balance - fixed that
  3. Some of the date formatters were rewritten (just to avoid installing dayjs package)
  4. Also made some small refactoring e.g. created some shared components, fixed some other small bugs

Create lock:

Screen.Recording.2024-08-07.at.21.45.39.mov

Increase Amount:

Screen.Recording.2024-08-07.at.21.46.19.mov

Increase unlock time

Screen.Recording.2024-08-07.at.21.48.10.mov

Claim view

Screenshot 2024-08-07 at 21 37 37

Wallet not connected view

image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:04am
govern ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:04am
launch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:04am
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:04am
tokenomics 🛑 Canceled (Inspect) Aug 9, 2024 0:04am

Copy link
Collaborator

@oaksprout oaksprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the functionality I could – it's working well.

I wasn't able to test the claiming logic because it will take 1 week, but on the 15th I'll be able to test it.

Copy link
Collaborator

@truemiller truemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, a few minor pointers

Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added minor suggestions

apps/govern/common-util/functions/requests.ts Outdated Show resolved Hide resolved
apps/govern/common-util/functions/requests.ts Outdated Show resolved Hide resolved
apps/govern/common-util/functions/requests.ts Show resolved Hide resolved
apps/govern/common-util/functions/time.ts Show resolved Hide resolved
apps/govern/components/VeOlas/CreateLockModal.tsx Outdated Show resolved Hide resolved
apps/govern/components/VeOlas/UnlockTimeInput.tsx Outdated Show resolved Hide resolved
apps/govern/hooks/useFetchBalances.ts Show resolved Hide resolved
apps/govern/hooks/useFetchBalances.ts Show resolved Hide resolved
apps/govern/hooks/useFetchBalances.ts Outdated Show resolved Hide resolved
apps/govern/components/VeOlas/VeOlasManage.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants