doc: internal audit ref AIP-1/Bonding

audits/README.md

@@ -10,5 +10,7 @@ An internal audit with a focus on depository implementation v.1.0.1 is located i
 
 An internal audit with a focus on PoAA Staking is located in this folder: [internal audit 4](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal4).
 
+An internal audit with a focus on AIP-1 (bonding) is located in this folder: [internal audit 5](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal5).
+
 ### External audit
 Audit reports: [v1](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/Autonolas%20Tokenomics%20Smart%20Contract%20Audit.pdf) and [v2](https://sourcehat.com/audits/AutonolasTokenomics/).

audits/internal5/README.md

@@ -0,0 +1,61 @@
+# Internal audit of autonolas-tokenomics
+The review has been performed based on the contract code in the following repository:<br>
+`https://github.com/valory-xyz/autonolas-tokenomics` <br>
+commit: `12101b49a2dcdc7a7378f416ddb1611e10459b67` or `tag: v1.3.0-pre-internal-audit`<br> 
+
+## Objectives
+The audit focused on contracts related to AIP-1 implementation (Bonding) in this repo.
+
+### Flatten version
+Flatten version of contracts. [contracts](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal5/analysis/contracts) 
+
+### Coverage: N/A
+In this commit, the tests are in the process of being reworked and therefore the coverage section does not make sense.
+
+### Storage and proxy
+Using sol2uml tools: https://github.com/naddison36/sol2uml <br>
+```
+npm link sol2uml --only=production
+sol2uml storage contracts/ -f png -c Tokenomics -o audits/internal4/analysis/storage
+Generated png file audits/internal5/analysis/storage/Tokenomics.png
+```
+[Tokenomics-storage](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal5/analysis/storage/Tokenomics.png) <br>
+current deployed: <br>
+[Tokenomics-storage-current](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal4/analysis/storage/Tokenomics.png) <br>
+The new slot allocation for Tokenomics (critical as proxy pattern) does not affect the previous one. 
+
+### Security issues.
+#### Problems found instrumentally
+Several checks are obtained automatically. They are commented. Some issues found need to be fixed. <br>
+All automatic warnings are listed in the following file, concerns of which we address in more detail below: <br>
+[slither-full](https://github.com/valory-xyz/autonolas-tokenomics/blob/main/audits/internal5/analysis/slither_full.txt) <br>
+
+#### Issue
+1. minOLASLeftoverAmount never setupped/updated
+```
+    // Minimum amount of supply such that any value below is given to the bonding account in order to close the product
+    uint256 public minOLASLeftoverAmount;
+```
+2. Reentrancy after ERC721 "safe" mint in deposit
+```
+	External calls:
+	- _safeMint(msg.sender,bondId) (Depository-flatten.sol#891)
+		- require(bool,string)(ERC721TokenReceiver(to).onERC721Received(msg.sender,address(0),id,) == ERC721TokenReceiver.onERC721Received.selector,UNSAFE_RECIPIENT) (Depository-flatten.sol#461-465)
+	After adding _safeMint(msg.sender, bondId), it became clearly susceptible reentrancy attack.
+    We need to add explicit protection against reentrancy.
+```
+#### Genaral notes: more tests need to be done, needed re-audit later
+```
+trackServiceDonations requires a large number of tests and coverage of all scenarios.
+```
+#### Notes for discussion: epsilonRate
+```
+in this implementation epsilonRate is deprecated and simply not used. perhaps it makes sense (?) to use this dimensionless coefficient as a limiter.
+// The IDF depends on the epsilonRate value, idf = 1 + epsilonRate, and epsilonRate is bound by 17 with 18 decimals
+new
+// IDF = 1 + normalized booster
+idf = 1e18 + discountBooster;
+maybe idf = min(1e18 + discountBooster, 1e18 + epsilonRate)
+Moreover, according to calculations discountBooster <= 1e18 << max(epsilonRate)
+```
+