Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding message when using brackets in the CD's name value #128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Feb 14, 2025

Fixes #123

@ptoffy ptoffy requested review from 0xTim and gwynne as code owners February 14, 2025 12:21
@penny-for-vapor
Copy link

penny-for-vapor bot commented Feb 14, 2025

Benchmark Report for d091a33

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-02-14 17:01:29 UTC

The baseline 'Fix decoding message when using brackets in the CDs name value' is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline 'Fix decoding message when using brackets in the CDs name value'

Host '698e2d15a3eb' with 2 'aarch64' processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Parser

CollatingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

CollatingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 8 8 8 8 8 8 8 1

CollatingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 530 540 551 551 560 570 570 20

StreamingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

StreamingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 6 6 6 6 6 6 6 1

StreamingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 510 510 510 520 520 540 540 20

Serializer

100xSerializerCPUTime_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 210 220 220 220 220 220 220 20

SerializerAllocations_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 3086 3086 3086 3086 3086 3086 3086 1

SerializerAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 3 3 3 3 3 3 3 1

@ptoffy ptoffy requested review from MahdiBM and gwynne February 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoded dictionaries can't necessarily be decoded
4 participants