-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding message when using brackets in the CD's name value #128
Open
ptoffy
wants to merge
5
commits into
main
Choose a base branch
from
brackets-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Report for d091a33✅ Pull request has no significant performance differences ✅ Click to expand comparison resultBenchmark check running at 2025-02-14 17:01:29 UTCThe baseline 'Fix decoding message when using brackets in the CDs name value' is EQUAL to the defined thresholds. Click to expand benchmark resultBaseline 'Fix decoding message when using brackets in the CDs name value'
ParserCollatingParserAllocations_256MiB
CollatingParserAllocations_Empty
CollatingParserCPUTime_256MiB
StreamingParserAllocations_256MiB
StreamingParserAllocations_Empty
StreamingParserCPUTime_256MiB
Serializer100xSerializerCPUTime_1024Parts
SerializerAllocations_1024Parts
SerializerAllocations_Empty
|
MahdiBM
reviewed
Feb 16, 2025
gwynne
requested changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123