-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/radio group accessibility #1848
Merged
haoziqaq
merged 5 commits into
varletjs:dev
from
harksha:feature/radio-group-accessibility
Feb 1, 2025
Merged
Feature/radio group accessibility #1848
haoziqaq
merged 5 commits into
varletjs:dev
from
harksha:feature/radio-group-accessibility
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@grozavioana is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
@varlet/cli
@varlet/icons
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/import-resolver
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
@haoziqaq please check chinese docs - I translated using AI :) |
thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update according to w3c https://www.w3.org/WAI/ARIA/apg/patterns/radio/
tabindex
based on checked state - changing radio options should not be achieved through tab key - only initial focusrole="radio"
andaria-checked
attributes to radio component<div>
to<li>
for better semanticsariaLabel
prop to radio group for improved accessibility<ul>
withrole="radiogroup"
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.