feat(backups/CBT): retry data_destroy when error is VDI_IN USE #7960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-Nollet
requested changes
Sep 5, 2024
julien-f
reviewed
Sep 10, 2024
julien-f
reviewed
Sep 10, 2024
julien-f
force-pushed
the
feat_retry_remove_snapshot
branch
from
aaa8bc1
to
7b1cb16
Compare
sometimes the capi take too long to detach the VDI in this case, the timeout is fixed at 4s, non modifiable when the timeout is reached the xapi raise a VDI_IN_USE error this is an internal process of the xapi This commit add a retry on XO side to give more room for the xapi to work through this process, as XO already do it one vdi destroying fix #7826
Co-authored-by: Julien Fontanet <[email protected]>
julien-f
force-pushed
the
feat_retry_remove_snapshot
branch
from
7b1cb16
to
67a9dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes the capi take too long to detach the VDI
in this case, the timeout is fixed at 4s, non modifiable
when the timeout is reached the xapi raise a VDI_IN_USE error
this is an internal process of the xapi
This commit add a retry on XO side to give more room for the xapi
to work through this process, as XO already do it one vdi destroying
fix #7826
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md