Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB-332-improve-pricing-section #60

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

paulinabjacykowska
Copy link
Contributor

This PR consists of changes presented here.

Except of those changes we also decided to increase size of a card on hover.

@paulinabjacykowska paulinabjacykowska marked this pull request as draft August 3, 2023 06:57
Copy link
Contributor

@mkaliszewski mkaliszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 1 non-blocking comment.

Comment on lines 65 to 70
additionalStyles: {
backgroundColor: '#ECF0F1',
borderRadius: 32,
padding: 7,
transition: 'all 0.2s ease-out',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the code is repeated in 3 places. Let's put it into the additionalStyles variable above the pricingCards definition.

@paulinabjacykowska paulinabjacykowska marked this pull request as ready for review August 3, 2023 09:52
@paulinabjacykowska paulinabjacykowska merged commit 7d06d7a into master Aug 3, 2023
1 check passed
@paulinabjacykowska paulinabjacykowska deleted the FB-332-pricing-section branch August 3, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants