Migrated SelectField tests to @testing-library/react
#1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Core
kestarumper
changed the title
SelectField testsSelectField tests to @testing-library/react
github-actions
bot
added
the
Area: Infra
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
=======================================
Coverage 94.60% 94.61%
=======================================
Files 231 231
Lines 3821 3823 +2
Branches 1029 1030 +1
=======================================
+ Hits 3615 3617 +2
Misses 82 82
Partials 124 124 ☔ View full report in Codecov by Sentry. |
kestarumper
requested changes
Mar 8, 2024
Comment on lines
67
to
98
| test('<SelectField> - renders a select which correctly reacts on change (uncheck) by value', () => { | ||
| const onChange = jest.fn(); | ||
| renderWithZod({ | ||
| element: <SelectField fieldType={Array} name="x" onChange={onChange} />, | ||
| schema: z.object({ x: z.enum(['a', 'b']) }), | ||
| }); | ||
| const select = screen.getByRole('listbox'); | ||
| fireEvent.change(select, { target: { value: '' } }); | ||
| expect(onChange).toHaveBeenCalledWith([]); | ||
| }); | ||
|
|
||
| test('<SelectField> - renders a select which correctly reacts on change (uncheck) by selectedIndex', () => { | ||
| const onChange = jest.fn(); | ||
| renderWithZod({ | ||
| element: <SelectField fieldType={Array} name="x" onChange={onChange} />, | ||
| schema: z.object({ x: z.enum(['a', 'b']) }), | ||
| }); | ||
| const select = screen.getByRole('listbox'); | ||
| fireEvent.change(select, { target: { selectedIndex: -1 } }); | ||
| expect(onChange).toHaveBeenCalledWith([]); | ||
| }); | ||
|
|
||
| test('<SelectField> - renders a select which correctly reacts on change (checked) by selectedIndex', () => { | ||
| const onChange = jest.fn(); | ||
| renderWithZod({ | ||
| element: <SelectField fieldType={Array} name="x" onChange={onChange} />, | ||
| schema: z.object({ x: z.enum(['a', 'b']) }), | ||
| }); | ||
| const select = screen.getByRole('listbox'); | ||
| fireEvent.change(select, { target: { selectedIndex: 0 } }); | ||
| expect(onChange).toHaveBeenCalledWith(['a']); | ||
| }); |
There was a problem hiding this comment.
Can we add information to the test name that its type is fieldType={Array}? We can name it multiple.
Monteth
previously approved these changes
Mar 8, 2024
Co-authored-by: Volodymyr Zakhovaiko <[email protected]>
kestarumper
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of #1130