Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated SelectField tests to @testing-library/react #1351

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented Jun 16, 2024

  • Migrated MUI, AntD, and Semantic tests
  • Tests weren't moved to the suites. They still need refactoring, but it is a good starting point. At least the enzyme was removed.
  • I didn't check skipTestIf(options?.theme === 'antd') tests in suites. Maybe we should implement them in the packages/uniforms-antd/__tests__/SelectField.tsx file.
  • I left this comment as some of tests can be moved to suites in the future.
// FIXME: MUI select does not work with new RTL test implementation
// suites.testSelectField(theme.SelectField, { showInlineError: true });

@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package labels Jun 16, 2024
@piotrpospiech piotrpospiech linked an issue Jun 16, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (1bfe92a) to head (3dc1e4a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   95.03%   94.90%   -0.14%     
==========================================
  Files         175      175              
  Lines        2902     2902              
  Branches      778      778              
==========================================
- Hits         2758     2754       -4     
  Misses         59       59              
- Partials       85       89       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zaxovaiko
zaxovaiko previously approved these changes Jun 28, 2024
zendranm
zendranm previously approved these changes Jul 5, 2024
@Monteth Monteth dismissed stale reviews from zendranm and zaxovaiko via fffdea5 July 19, 2024 11:04
@piotrpospiech piotrpospiech merged commit e2c77bf into master Jul 25, 2024
7 of 8 checks passed
@piotrpospiech piotrpospiech deleted the select-field-tests branch July 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate SelectField tests to @testing-library/react
5 participants