-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated SelectField
tests to @testing-library/react
#1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpospiech
requested review from
kestarumper,
Monteth,
zaxovaiko,
zendranm and
ErnestTeluk
June 16, 2024 16:22
github-actions
bot
added
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: AntD
Affects the uniforms-antd package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
labels
Jun 16, 2024
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 95.03% 94.90% -0.14%
==========================================
Files 175 175
Lines 2902 2902
Branches 778 778
==========================================
- Hits 2758 2754 -4
Misses 59 59
- Partials 85 89 +4 ☔ View full report in Codecov by Sentry. |
zaxovaiko
previously approved these changes
Jun 28, 2024
zendranm
previously approved these changes
Jul 5, 2024
Co-authored-by: Konrad Bosak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: AntD
Affects the uniforms-antd package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipTestIf(options?.theme === 'antd')
tests in suites. Maybe we should implement them in thepackages/uniforms-antd/__tests__/SelectField.tsx
file.