Enable mui SelectField suite tests #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## select-field-tests #1355 +/- ##
======================================================
+ Coverage 94.14% 94.23% +0.09%
======================================================
Files 200 200
Lines 3314 3314
Branches 895 895
======================================================
+ Hits 3120 3123 +3
Misses 70 70
+ Partials 124 121 -3 ☔ View full report in Codecov by Sentry. |
zaxovaiko
approved these changes
Jun 28, 2024
kestarumper
approved these changes
Jul 1, 2024
| const select = screen.getByRole('combobox'); | ||
| expect(select).toBeDisabled(); | ||
| }); | ||
| skipTestIf(['mui', 'antd'].includes(options?.theme ?? ''))( |
There was a problem hiding this comment.
[very optional]
TBH, I'm not convinced by this suggestion either, but at the same time, I don't know how to approach this change.
If you come up with a better name than shouldSkipTestBecauseOfTheme then go for it 😅
Suggested change
| skipTestIf(['mui', 'antd'].includes(options?.theme ?? ''))( | |
| const shouldSkipTestBecauseOfTheme = ['mui', 'antd'].includes(options?.theme ?? '') | |
| // somewhere above | |
| // . | |
| // . | |
| // . | |
| skipTestIf(shouldSkipTestBecauseOfTheme)( |
There was a problem hiding this comment.
I'd instead use isTheme(['mui', 'antd']) to ensure flexibility and ease of change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of this PR:
HTMLInputElementsThe local tests that cover the same area as the suites with the new "filter" were not removed, as I'm not sure if it is the correct approach. I want to ask you for your opinion on that.