Support v5 of AntD #1261 #1373
Closed
Support v5 of AntD #1261 #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datefield now uses dayjs selectfield was self-referencing
made showTime default to false
github-actions
bot
added
Area: Infra
|
Hi @bmartin1134! Thanks for the contribution. We will try to review it soon. |
|
Hi again! We were working on official React 18 support last week. We updated AntD to v5 as well as v4 doesn't support React v18. We decided to do that in our pull request as a lot of extra changes were required compared to this pull request. However, we appreciate your input as the changes you made were very helpful to us and provided a good starting point. You can check #1376 for more information. I'm closing this pull request. If you have questions, feel free to add them to #1376 pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support v5 of AntD #1261
Added support for antD version 5.
There are some extra @ts-ignore on DateField and SelectField that might need to be looked at.
Also, i added some rule exclusions on the .eslintrc.json to get it to compile so i could use it locally.
Check the changes.